Use json gem instead of oj #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was reading this blog post: https://byroot.github.io/ruby/json/2024/12/15/optimizing-ruby-json-part-1.html where the new maintainer of the json gem says: > I was recently made maintainer of the json gem, and aside from fixing some old bugs, I focused quite a bit on its > performance, so that it is now the fastest JSON parser and generator for Ruby on most benchmarks. Since JSON is the default Ruby gem and is also now the fastest (by his claim, at least), it seems like it'd be nice to go with that and avoid an extra dependency, unless we have another reason to use Oj.
|
@alexstoick thanks for fixing the specs! Does this look OK to merge @alexstoick @reidnimz? (After the holidays) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading this blog post: https://byroot.github.io/ruby/json/2024/12/15/optimizing-ruby-json-part-1.html where the new maintainer of the json gem says:
Since JSON is the default Ruby gem and is also now the fastest (by his claim, at least), it seems like it'd be nice to go with that and avoid an extra dependency, unless we have another reason to use Oj.
NOTE: Tests on master seem to be failing. See this test PR: #74